-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace os.path for pathlib in NLU module #7118
Conversation
…os.path-pathlib
…os.path-pathlib
…e-os.path-pathlib
…os.path-pathlib
Thanks for submitting a pull request 🚀 @JustinaPetr will take a look at it as soon as possible ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on that! 🚀
Overall looks very good, just left several comments!
rasa/nlu/featurizers/sparse_featurizer/count_vectors_featurizer.py
Outdated
Show resolved
Hide resolved
@silvasara Is the PR ready for the review again? If yes, please re-request the review 👍 |
Only the author of the PR can request the review again. @RomuloSouza , can you request it again, please? |
…os.path-pathlib
c4765e0
to
16a71c5
Compare
16a71c5
to
8c7bebb
Compare
…os.path-pathlib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments 👍
Left a couple more, and we're good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot 💯
…os.path-pathlib
@degiz are you going to merge this? We'd like to continue the issue for the remaining modules, should we wait for these changes to be merged? |
@RomuloSouza I've already approved this patch set, so feel free to update this branch with the latest |
…os.path-pathlib
…os.path-pathlib
@degiz I've updated with the latest |
…/rasa into replace-os.path-pathlib
Yes, that's the case. Please check the failing jobs and address the issues 👍 |
…os.path-pathlib
c4ddf57
to
b425e6c
Compare
@degiz I fixed the issues in the CI and I still can't merge this PR |
@RomuloSouza the branch is already behind the |
…os.path-pathlib
…os.path-pathlib
@RomuloSouza it would be great if you could address the open issues so we don't loose out on this cool contribution - I'll close this as it is stale. |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)